Allow execution of a pre-build command before testing a package on Windows #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
windows-pre-build
branch
2 times, most recently
from
95df194 to
64edffc
Compare
ahoppen
force-pushed
the
windows-pre-build
branch
from
64edffc to
3a3cc36
Compare
| } else { | ||
| $Image = "swift:${{ matrix.swift_version }}-windowsservercore-ltsc2022" | ||
| } | ||
| docker pull $Image |
There was a problem hiding this comment.
could we have save the image name as output just to remove duplication below:
Suggested change
| docker pull $Image | |
| docker pull $Image | |
| echo "image=$Image" >> "$GITHUB_OUTPUT" |
Then in the "Create test script" section we can do
docker run -v ${{ github.workspace }}:C:\source -v $env:TEMP\test-script:C:\test-script ${{ steps.pull-docker-image.outputs.image }}" C:\test-script\run.cmd(need to set the id of the step to pull-docker-image)
There was a problem hiding this comment.
Great suggestion. Updated and kicked off another test run: https://github.com/ahoppen/swift-format/actions/runs/11505824164
ahoppen
force-pushed
the
windows-pre-build
branch
2 times, most recently
from
d2dfd01 to
db4d3ba
Compare
ahoppen
force-pushed
the
windows-pre-build
branch
from
db4d3ba to
a77f41b
Compare
justice-adams-apple
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivating change for this is swiftlang/swift-format#863.
While at it, also unify the release versions and nightly versions of Windows into a single matrix, avoiding code duplications and also making them show up in a single matrix in the GitHub workflow run, which looks nicer.
Example run: https://github.com/ahoppen/swift-format/actions/runs/11502681752